This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author drukker
Recipients christian.heimes, drukker, orsenthil, schu, stac
Date 2009-11-10.18:26:02
SpamBayes Score 2.8162532e-07
Marked as misclassified No
Message-id <1257877564.82.0.557633848375.issue1235@psf.upfronthosting.co.za>
In-reply-to
Content
orsenthil: I reverted the changes that make Windows and Unix use the
same code in Patch Set 3, and briefly mentioned the reason for that in
the Rietveld app.  I should have mentioned it here too.

It was because it actually makes the implementation on Unix worse, since
the Windows implementation reads all data in memory.  (The subprocess
module documentation has this note: "The data read is buffered in
memory, so do not use this method if the data size is large or unlimited.")

I tried replacing subprocess.PIPE with rfile/wfile, but it turns out
that that won't work, because on Windows socket.fileno() cannot be used
where file descriptors can be used, as the socket module documentation
states.
History
Date User Action Args
2009-11-10 18:26:04drukkersetrecipients: + drukker, orsenthil, christian.heimes, schu, stac
2009-11-10 18:26:04drukkersetmessageid: <1257877564.82.0.557633848375.issue1235@psf.upfronthosting.co.za>
2009-11-10 18:26:02drukkerlinkissue1235 messages
2009-11-10 18:26:02drukkercreate