Message94875
A couple of points:
- if the method is Windows-specific, I don't think it shouldn't bear a
name as generic as "read_registry()". There are "registries" on other
systems.
- the method should probably raise early on non-Windows systems (raise
NotImplementedError?)
- please fix the coding style; don't collapse a "try", "except" or
"finally" and the following statement on a single line
- in the tests, rather than defining an empty test case on non-Windows
systems, make the tests skip (for example, call self.skipTest() |
|
Date |
User |
Action |
Args |
2009-11-04 01:26:23 | pitrou | set | recipients:
+ pitrou, ggenellina, tercero12 |
2009-11-04 01:26:16 | pitrou | set | messageid: <1257297976.55.0.671427371856.issue4969@psf.upfronthosting.co.za> |
2009-11-04 01:26:15 | pitrou | link | issue4969 messages |
2009-11-04 01:26:14 | pitrou | create | |
|