Message 93841 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pitrou
Recipients	akuchling, dbonner, niemeyer, pitrou, r.david.murray, therve, thomaslee
Date	2009-10-10.20:11:33
SpamBayes Score	1.1448396e-06
Marked as misclassified	No
Message-id	<1255205495.53.0.134284426461.issue1625@psf.upfronthosting.co.za>
In-reply-to

Content
As far as I can tell, the patch looks mostly good. I just wonder, in Util_HandleBZStreamEnd(), why you don't set self->mode to MODE_CLOSED if BZ2_bzReadOpen() fails. As a sidenote, the bz2 module implementation seems to have changed quite a bit between trunk and py3k, so if you want it to be backported to trunk (2.7), you'll have to provide a separate patch.

As far as I can tell, the patch looks mostly good.
I just wonder, in Util_HandleBZStreamEnd(), why you don't set self->mode
to MODE_CLOSED if BZ2_bzReadOpen() fails.

As a sidenote, the bz2 module implementation seems to have changed quite
a bit between trunk and py3k, so if you want it to be backported to
trunk (2.7), you'll have to provide a separate patch.

History
Date	User	Action	Args
2009-10-10 20:11:35	pitrou	set	recipients: + pitrou, akuchling, niemeyer, therve, thomaslee, r.david.murray, dbonner
2009-10-10 20:11:35	pitrou	set	messageid: <1255205495.53.0.134284426461.issue1625@psf.upfronthosting.co.za>
2009-10-10 20:11:34	pitrou	link	issue1625 messages
2009-10-10 20:11:33	pitrou	create