Author boya
Recipients boya, haypo
Date 2009-09-10.18:02:01
SpamBayes Score 2.48516e-05
Marked as misclassified No
Message-id <1252605723.47.0.801172577791.issue6817@psf.upfronthosting.co.za>
In-reply-to
Content
Victor,

I corrected both issues of the patch according to your first comment. 

This patch did not fix the Windows implementation. It seems that there
will not be buffer overflow in the Windows implementation, since if the
buffer is small for GetCurrentDirectoryW(), the code allocates a new
buffer for it with enough length by the following code:

        len = GetCurrentDirectoryW(sizeof wbuf/ sizeof wbuf[0], wbuf);
	if (len >= sizeof wbuf/ sizeof wbuf[0]) {
		wbuf2 = malloc(len * sizeof(wchar_t));
		if (wbuf2)
			len = GetCurrentDirectoryW(len, wbuf2);
	}
History
Date User Action Args
2009-09-10 18:02:04boyasetrecipients: + boya, haypo
2009-09-10 18:02:03boyasetmessageid: <1252605723.47.0.801172577791.issue6817@psf.upfronthosting.co.za>
2009-09-10 18:02:02boyalinkissue6817 messages
2009-09-10 18:02:01boyacreate