Author amaury.forgeotdarc
Recipients amaury.forgeotdarc, loewis, msaghaei
Date 2009-07-02.12:23:28
SpamBayes Score 5.99637e-06
Marked as misclassified No
Message-id <1246537416.36.0.293289564581.issue6396@psf.upfronthosting.co.za>
In-reply-to
Content
IMO, the *_FromFormat functions are wrong to decide whether the args
object is a mapping. the code is:
    if (Py_TYPE(args)->tp_as_mapping && !PyTuple_Check(args) &&
        !PyObject_TypeCheck(args, &PyBaseString_Type))
        dict = args;

But heap types always fill tp_as_mapping: it points to
PyHeapTypeObject.as_mapping, whose members may be NULL...
PyMapping_Check() would be more appropriate.
History
Date User Action Args
2009-07-02 12:23:36amaury.forgeotdarcsetrecipients: + amaury.forgeotdarc, loewis, msaghaei
2009-07-02 12:23:36amaury.forgeotdarcsetmessageid: <1246537416.36.0.293289564581.issue6396@psf.upfronthosting.co.za>
2009-07-02 12:23:29amaury.forgeotdarclinkissue6396 messages
2009-07-02 12:23:28amaury.forgeotdarccreate