Author pitrou
Recipients janglin, pitrou
Date 2009-07-01.15:11:52
SpamBayes Score 0.00289078
Marked as misclassified No
Message-id <1246461114.22.0.192646662001.issue6394@psf.upfronthosting.co.za>
In-reply-to
Content
I'm not qualified to comment on Windows-specific code, but two things:
- you should raise an appropriate exception on failure, not return -1
- the file is intended with tabs, not spaces
History
Date User Action Args
2009-07-01 15:11:54pitrousetrecipients: + pitrou, janglin
2009-07-01 15:11:54pitrousetmessageid: <1246461114.22.0.192646662001.issue6394@psf.upfronthosting.co.za>
2009-07-01 15:11:53pitroulinkissue6394 messages
2009-07-01 15:11:53pitroucreate