Message 85827 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	doerwalter
Recipients	doerwalter, vstinner
Date	2009-04-09.21:26:05
SpamBayes Score	1.1563659e-09
Marked as misclassified	No
Message-id	<1239312367.48.0.588461300829.issue5108@psf.upfronthosting.co.za>
In-reply-to

Content
The problem with your patch is that it calls PyUnicode_DecodeUTF8() twice. It would be better if step 1 in the code would include the %s format specifiers and step 3 would then call PyUnicode_DecodeUTF8() and put the result into the callresults buffer. BTW, I can't make your examples segfault. Attached is a new version of the patch that implements this. Could you test this new version to see if there's still a Valgrind report?

The problem with your patch is that it calls PyUnicode_DecodeUTF8()
twice. It would be better if step 1 in the code would include the %s
format specifiers and step 3 would then call PyUnicode_DecodeUTF8() and
put the result into the callresults buffer.

BTW, I can't make your examples segfault.

Attached is a new version of the patch that implements this. Could you
test this new version to see if there's still a Valgrind report?

History
Date	User	Action	Args
2009-04-09 21:26:07	doerwalter	set	recipients: + doerwalter, vstinner
2009-04-09 21:26:07	doerwalter	set	messageid: <1239312367.48.0.588461300829.issue5108@psf.upfronthosting.co.za>
2009-04-09 21:26:06	doerwalter	link	issue5108 messages
2009-04-09 21:26:06	doerwalter	create