This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mark.dickinson
Recipients amaury.forgeotdarc, benjamin.peterson, brett.cannon, christian.heimes, georg.brandl, gpolo, lemburg, mark.dickinson, pitrou, rhettinger
Date 2009-02-02.22:08:55
SpamBayes Score 2.4031797e-09
Marked as misclassified No
Message-id <1233612538.2.0.243562969508.issue1717@psf.upfronthosting.co.za>
In-reply-to
Content
All relevant changes from the py3k-issue1717 branch have now been merged into the py3k 
branch (and from there into the 3.0 maintenance branch), in a series of revisions.  
Here they are, listed in py3k/release30-maint pairs:

r69188, r69189,
r69190, r69191,
r69192, r69193,
r69214, r69215,
r69218, r69221,
r69224, r69225.

The idea to raise TypeError on non-NULL tp_compare was abandoned after Martin pointed 
out that it would be a binary incompatible change _[1], but Nick Coghlan suggested a 
DeprecationWarning when tp_compare is non-NULL and tp_richcompare is NULL _[2], and 
remarked that the warning should also be implemented for Python 2.7 when run with the -
3 option.

Still to do before this can be closed:

 - fix up Doc/extending/newtypes.rst;  I think Georg has said he'll
   take care of this, so once everything else is done I'll just reassign
   this issue to him and let him get on with it.

 - add Nick Coghlan's suggested DeprecationWarning.

 - grep through the sources looking for tp_compare, __cmp__, cmpfunc,
   PyObject_Cmp, PyObject_Compare and cmp, and check all remaining
   references are legitimate.

 - update pybench;  there's a separate issue already open for this.
   (issue 4704), and it looks like Antoine and Marc-André are on the
   case.

 - anything else that I've forgotten.

Thanks everyone for your help so far, especially Christian for much of
the original code and Antoine for code and review.

[1] http://mail.python.org/pipermail/python-dev/2009-February/085797.html
[2] http://mail.python.org/pipermail/python-dev/2009-February/085809.html
History
Date User Action Args
2009-02-02 22:08:58mark.dickinsonsetrecipients: + mark.dickinson, lemburg, brett.cannon, georg.brandl, rhettinger, amaury.forgeotdarc, pitrou, christian.heimes, benjamin.peterson, gpolo
2009-02-02 22:08:58mark.dickinsonsetmessageid: <1233612538.2.0.243562969508.issue1717@psf.upfronthosting.co.za>
2009-02-02 22:08:57mark.dickinsonlinkissue1717 messages
2009-02-02 22:08:55mark.dickinsoncreate