On Mon, Feb 2, 2009 at 12:42, Martin von Gagern <report@bugs.python.org> wrote:
>
> Martin von Gagern <Martin.vGagern@gmx.net> added the comment:
>
> Next iteration. With magic number, and now also closing the file again.
> I changed from unpack and number comparison to pack and string
> comparison, makes things a bit easier, as there is only one comparison,
> and as underflow of the packed data isn't an issue any more.
>
> Would you prefer the use of private marshal functions, as bootstrap
> does, over the struct packing as I do here?
>

No since importlib only does it that way for bootstrapping
considerations (might end up at the implementation of import itself so
it has special requirements).

> Looking forward to your review.

I have not looked, Martin, but are proper tests in place already in
the standard library? If not I would appreciate tests.