Message 80504 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pitrou
Recipients	amaury.forgeotdarc, benjamin.peterson, brett.cannon, christian.heimes, georg.brandl, lemburg, mark.dickinson, pitrou, rhettinger
Date	2009-01-25.12:38:02
SpamBayes Score	0.0026645814
Marked as misclassified	No
Message-id	<1232887084.06.0.897519243364.issue1717@psf.upfronthosting.co.za>
In-reply-to

Content
Quick comments on your patch: - two files have unwanted modifications on non-ASCII characters (Lib/heapq.py and Lib/sqlite3/test/hooks.py) - you haven't renamed "__cmp__" to "_cmp" in Lib/xmlrpc/client.py: deliberate? - in Lib/heapq.py, there's a "_cmp__" which should be "_cmp"

Quick comments on your patch:
- two files have unwanted modifications on non-ASCII characters
(Lib/heapq.py and Lib/sqlite3/test/hooks.py)
- you haven't renamed "__cmp__" to "_cmp" in Lib/xmlrpc/client.py:
deliberate?
- in Lib/heapq.py, there's a "_cmp__" which should be "_cmp"

History
Date	User	Action	Args
2009-01-25 12:38:04	pitrou	set	recipients: + pitrou, lemburg, brett.cannon, georg.brandl, rhettinger, amaury.forgeotdarc, mark.dickinson, christian.heimes, benjamin.peterson
2009-01-25 12:38:04	pitrou	set	messageid: <1232887084.06.0.897519243364.issue1717@psf.upfronthosting.co.za>
2009-01-25 12:38:03	pitrou	link	issue1717 messages
2009-01-25 12:38:03	pitrou	create