Author loewis
Recipients belopolsky, gpolo, josm, loewis
Date 2008-12-21.23:52:12
SpamBayes Score 8.68608e-05
Marked as misclassified No
Message-id <494ED6AA.9080609@v.loewis.de>
In-reply-to <1229902969.15.0.878875875084.issue1706039@psf.upfronthosting.co.za>
Content
> It isn't being careful when calling PyErr_SetFromErrno inside the
> Py_UniversalNewlineFread function since this function is being called
> all over fileobject after releasing the GIL.. so, isn't this just a
> matter of adding pairs of PyGILState_Ensure/PyGILState_Release around
> these calls to PyErr_SetFromErrno in this specific function ?

Perhaps that could fix this problem (or perhaps not - is
PyGILState_Ensure guaranteed to do the right thing, even in the
presence of multiple interpreters?)

My concern is that this patch may contain other bugs. I am apparently
incapable of reviewing it correctly, and nobody else has offered a
careful review.
History
Date User Action Args
2008-12-21 23:52:13loewissetrecipients: + loewis, belopolsky, josm, gpolo
2008-12-21 23:52:12loewislinkissue1706039 messages
2008-12-21 23:52:12loewiscreate