Author gregory.p.smith
Recipients christian.heimes, gregory.p.smith, terry.reedy
Date 2008-12-04.22:50:33
SpamBayes Score 0.000101805
Marked as misclassified No
Message-id <1228431035.03.0.112028466492.issue4533@psf.upfronthosting.co.za>
In-reply-to
Content 
patch looks good to me.

nitpick comments: use += instead of = and + in:

newsize = newsize + newsize
 and
newsize = newsize + BIGCHUNK.

As for the XXX about overflow, so long as BUFSIZ is not defined to be an
insanely large number (it should never be) this will be fine.  add a
preprocessor test for that in.

#if (BUFSIZ >= 2**30)
#error "unreasonable BUFSIZ defined"
#endif
History
Date User Action Args
2008-12-04 22:50:35gregory.p.smithsetrecipients: + gregory.p.smith, terry.reedy, christian.heimes
2008-12-04 22:50:35gregory.p.smithsetmessageid: <1228431035.03.0.112028466492.issue4533@psf.upfronthosting.co.za>
2008-12-04 22:50:34gregory.p.smithlinkissue4533 messages
2008-12-04 22:50:34gregory.p.smithcreate