Message 76940 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	gregory.p.smith
Recipients	christian.heimes, gregory.p.smith, terry.reedy
Date	2008-12-04.22:50:33
SpamBayes Score	0.0001018051
Marked as misclassified	No
Message-id	<1228431035.03.0.112028466492.issue4533@psf.upfronthosting.co.za>
In-reply-to

Content
patch looks good to me. nitpick comments: use += instead of = and + in: newsize = newsize + newsize and newsize = newsize + BIGCHUNK. As for the XXX about overflow, so long as BUFSIZ is not defined to be an insanely large number (it should never be) this will be fine. add a preprocessor test for that in. #if (BUFSIZ >= 2**30) #error "unreasonable BUFSIZ defined" #endif

patch looks good to me.

nitpick comments: use += instead of = and + in:

newsize = newsize + newsize
 and
newsize = newsize + BIGCHUNK.

As for the XXX about overflow, so long as BUFSIZ is not defined to be an
insanely large number (it should never be) this will be fine.  add a
preprocessor test for that in.

#if (BUFSIZ >= 2**30)
#error "unreasonable BUFSIZ defined"
#endif

History
Date	User	Action	Args
2008-12-04 22:50:35	gregory.p.smith	set	recipients: + gregory.p.smith, terry.reedy, christian.heimes
2008-12-04 22:50:35	gregory.p.smith	set	messageid: <1228431035.03.0.112028466492.issue4533@psf.upfronthosting.co.za>
2008-12-04 22:50:34	gregory.p.smith	link	issue4533 messages
2008-12-04 22:50:34	gregory.p.smith	create