Message72344
This issue was missing a priority setting.
Alexander's range-sequence patch still applies cleanly to the Py3k
branch, and "make test" still runs correctly after applying it.
As Alexander notes above, range_contains does still need slightly better
handling of non-integer numbers - I suggest doing a numeric conversion
via PyNumber_Index(el) at the beginning of range_contains, and if that
conversion fails, do a conversion via PyNumber_Long(el) and immediately
return False if the result is not equal to el itself (i.e. only integer
values of non-integer types will be found in the range.
Since that explanation got kind of complicated, I've added a modified
patch that includes the above change, and adds a couple of additional
tests to ensure a non-integer floating point value won't be found in the
sequence. |
|
Date |
User |
Action |
Args |
2008-09-02 15:27:50 | ncoghlan | set | recipients:
+ ncoghlan, gvanrossum, facundobatista, amaury.forgeotdarc, mark.dickinson, belopolsky, pitrou |
2008-09-02 15:27:50 | ncoghlan | set | messageid: <1220369270.0.0.00180039288204.issue2690@psf.upfronthosting.co.za> |
2008-09-02 15:27:49 | ncoghlan | link | issue2690 messages |
2008-09-02 15:27:48 | ncoghlan | create | |
|