Author gregory.p.smith
Recipients giampaolo.rodola, gregory.p.smith, jbell
Date 2008-05-06.07:23:24
SpamBayes Score 0.00324772
Marked as misclassified No
Message-id <1210058607.88.0.585038766303.issue2628@psf.upfronthosting.co.za>
In-reply-to
Content
rather than using the array.array for your three byte header with manual
parsing, please use struct.unpack.

Whats a good way to test that this works?  It'd be nice to have a unit
test (a test_ftplib_net.py perhaps?) though I realize ftplib currently
has poor test coverage with no such explicit network test existing
beyond things the urllib tests might do.

also, could you make the appropriate documentation updates against
python trunk's Doc/lib/ftplib.rst.  Mention when & what servers you
found using this mode useful with if at all possible.
History
Date User Action Args
2008-05-06 07:23:28gregory.p.smithsetspambayes_score: 0.00324772 -> 0.00324772
recipients: + gregory.p.smith, giampaolo.rodola, jbell
2008-05-06 07:23:28gregory.p.smithsetspambayes_score: 0.00324772 -> 0.00324772
messageid: <1210058607.88.0.585038766303.issue2628@psf.upfronthosting.co.za>
2008-05-06 07:23:26gregory.p.smithlinkissue2628 messages
2008-05-06 07:23:25gregory.p.smithcreate