This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author mamrhein
Recipients belopolsky, flxkid, gvanrossum, jafo, mamrhein, vdupras
Date 2008-04-11.16:10:46
SpamBayes Score 0.025517436
Marked as misclassified No
Message-id <1207930249.81.0.0967369895117.issue1738@psf.upfronthosting.co.za>
In-reply-to
Content
Ok, I've set default arguments (back) to None. Revised patch attached.

Defaulting the match function to fnmatch doesn't change the behavior in
the "normal" case, i.e. when regular file / directory names are used,
like in the default value of ignore. It behaves different in two cases:
a) A string given in ignore contains wildcard character(s):
In this case this parameter would have no effect in the previous
implementation, because the string would not match any file / directory
name exactly. In the changed implementation all files / directories
matching the pattern would be ignored. If the wildcard(s) were included
by intent, this is what probably was intended; if they were included by
mistake, both version do not behave as intended.
b) File system is case-insensitive:
In this case the changed implementation will ignore files / directories
which the previous version did not ignore because of a case mismatch.
But, on such a file system this is what one would normally expect, I think.
So, in both cases, I feel the changed behavior is acceptable.
Or did I miss something?
History
Date User Action Args
2008-04-11 16:10:50mamrheinsetspambayes_score: 0.0255174 -> 0.025517436
recipients: + mamrhein, gvanrossum, jafo, belopolsky, flxkid, vdupras
2008-04-11 16:10:49mamrheinsetspambayes_score: 0.0255174 -> 0.0255174
messageid: <1207930249.81.0.0967369895117.issue1738@psf.upfronthosting.co.za>
2008-04-11 16:10:49mamrheinlinkissue1738 messages
2008-04-11 16:10:48mamrheincreate