Message 64832 - Python tracker

Author	jyasskin
Recipients	astrand, gregory.p.smith, jyasskin, mattjohnston, mpitt, schmir, timjr
Date	2008-04-02.03:02:19
SpamBayes Score	0.046811
Marked as misclassified	No
Message-id	<1207105340.86.0.506861428829.issue1068268@psf.upfronthosting.co.za>
In-reply-to

Content
I think the proper behavior on EINTR may depend on which subprocess call we're in. For example, the user can easily loop on .wait() herself if she wants to ignore EINTR. But it's a lot harder to loop on Popen() if the read() in _execute_child is interrupted. So my inclination would be to let EINTR be raised in the first case, and use a loop to handle it in the second. Regarding the patch, a wrapper function called as "retry_on_eintr(obj.write, data)" might be a cleaner way to do it.

I think the proper behavior on EINTR may depend on which subprocess call
we're in. For example, the user can easily loop on .wait() herself if
she wants to ignore EINTR. But it's a lot harder to loop on Popen() if
the read() in _execute_child is interrupted. So my inclination would be
to let EINTR be raised in the first case, and use a loop to handle it in
the second.

Regarding the patch, a wrapper function called as
"retry_on_eintr(obj.write, data)" might be a cleaner way to do it.

History
Date	User	Action	Args
2008-04-02 03:02:21	jyasskin	set	spambayes_score: 0.046811 -> 0.046811 recipients: + jyasskin, gregory.p.smith, astrand, mattjohnston, mpitt, timjr, schmir
2008-04-02 03:02:20	jyasskin	set	spambayes_score: 0.046811 -> 0.046811 messageid: <1207105340.86.0.506861428829.issue1068268@psf.upfronthosting.co.za>
2008-04-02 03:02:19	jyasskin	link	issue1068268 messages
2008-04-02 03:02:19	jyasskin	create