Message 57516 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	christian.heimes
Recipients	christian.heimes, gvanrossum, nnorwitz, roudkerk, theller
Date	2007-11-15.01:55:06
SpamBayes Score	0.032651737
Marked as misclassified	No
Message-id	<1195091707.56.0.212997950104.issue1378@psf.upfronthosting.co.za>
In-reply-to

Content
I've reviewed your patch and merged it was some pending changes of my own. The socket tests are passing on Windows. Great work :) UPDATE: * Added PyLong_FromSocket_t and PyLong_AsSocket_t to longobject.h to get rid of some 64bit warnings * Use name dup_socket() instead of dup(). For Windows developers it's too confusing to name it dup(). * Readded fromfd, but this time in C again.

I've reviewed your patch and merged it was some pending changes of my
own. The socket tests are passing on Windows. Great work :)

UPDATE:
* Added PyLong_FromSocket_t and PyLong_AsSocket_t to longobject.h to get
rid of some 64bit warnings
* Use name dup_socket() instead of dup(). For Windows developers it's
too confusing to name it dup().
* Readded fromfd, but this time in C again.

History
Date	User	Action	Args
2007-11-15 01:55:07	christian.heimes	set	spambayes_score: 0.0326517 -> 0.032651737 recipients: + christian.heimes, gvanrossum, nnorwitz, theller, roudkerk
2007-11-15 01:55:07	christian.heimes	set	spambayes_score: 0.0326517 -> 0.0326517 messageid: <1195091707.56.0.212997950104.issue1378@psf.upfronthosting.co.za>
2007-11-15 01:55:07	christian.heimes	link	issue1378 messages
2007-11-15 01:55:06	christian.heimes	create