Message51093
Logged In: YES
user_id=56214
I just looked at the current patch; please don't use
sys.modules.iteritems() in your search loop; it'll break if
touching a module causes another module to be imported.
This can happen if somebody is using one of the many "lazy
import" tools out there. Use .items() instead.
Second, there was a reason that the loop used
module.__name__ instead of the sys.modules keys; a module
can be listed under more than one sys.modules key, so the
loop was storing the *canonical* name of the module. I'm
not 100% positive this is a critical thing, but I'm
suspicious of the idea of just randomly choosing which of
the possible keys should be used.
|
|
| Date |
User |
Action |
Args |
| 2007-08-23 15:54:35 | admin | link | issue1553314 messages |
| 2007-08-23 15:54:35 | admin | create | |
|