Message51050
Logged In: YES
user_id=764593
(Responding to the patch, not directly to the conversation)
(1) (around lines 234) Do you really want two test cases
to compare equal because they have the same name, even if
that name is the default runTest?
(2) Have you made sense of the UnboundMethodType case? As
nearly as I can figure, the old behavior was to run call
the test case with a method name (which by default tried to
run it, using that string as a TestResult?!?, and then
returned None), and the new behavior just wraps this None
in a TestSuite.
(3) After patch, the callable case has a "return test"
which is dead code, because the other branches either
raised or returned on their own.
(4) Changing the raise from ValueError to TypeError would
make sense if not for backwards compatibility. Could you
use a custom error that inherits from both?
Please don't let these comments get you down; this is code
that needs cleaning. (The changes to not special-case
jython and to not rewalk the mro are particularly good --
because they don't do anything, having them in the code is
misleading.)
|
|
| Date |
User |
Action |
Args |
| 2007-08-23 15:54:29 | admin | link | issue1550273 messages |
| 2007-08-23 15:54:29 | admin | create | |
|