Logged In: YES 
user_id=21627

Thanks for the patch.

1) I could not see where you dealt with internal_connect in
the patch. However, as a connect can also be cancelled with
Ctrl-C, I think you need to deal with it, too.

2) I agree, renaming it would be good

3) you could come up with a macro to avoid code duplication
(relying on consistent naming of variables, but that might
confure more than help

4) This is almost right. The critical thing is that you read
errno much too late. errno is meant to be read immediately
after the system call. Any later system call can modify the
value - including all of the pthread calls that we do
in-between. So the right solution is to copy errno right
after select, into a local variable of the caller, and read
*that* variable. In order to avoid modifying SetFromErrno,
you can assign back to errno before calling it.