Message47541
Please have a close look at the attached patch.
Essentially, it fixes internal_select to not return
zero on error condition, and also adds a test for errno
at all calls to internal_select.
A few remarks:
1) as indicated in the patch, I'm not sure if errno
should also be tested in the internal_connect function;
2) 'timeout' is no longer a boolean indicating a
timeout condition, it should probably be renamed to
'selectresult' or something similar;
3) I'm not too happy with the fact that the
if(timeout==-1 && erro) test must be duplicated in a
lot of functions;
4) does it do the right thing? The check for
timeout==-1 MUST be there otherwise a lot of errors
turn up in the regression tests. With this patch they
run fine, btw
|
|
| Date |
User |
Action |
Args |
| 2007-08-23 15:41:18 | admin | link | issue1102879 messages |
| 2007-08-23 15:41:18 | admin | create | |
|