Author rodsenra
Recipients
Date 2005-03-20.14:04:07
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Logged In: YES 
user_id=9057

Against the [http://python.org/patches/  Patch Submission
Guidelines] this entry has uploaded both the whole file and
.tgz, but no patch file. 

The  large numbers of changes make it difficult to review.

All the changes were documented to the top of the file, I
don't believe they 
belong there. At least that is not complaint to the first
rule in 
http://www.python.org/patches/style.html

There are several OS X specific corrections that I'm unable
to reproduce/validate,  since I have no access to that
platform. 

The modules was renamed to wingwebbrowser.py and the test
case was built using this name. I believe this is
inadequate, the original module name should be  kept.

There are three categories of changes: bug fixes, internal
changes and interface changes.  IMO it would be better to
break this patch in at least three, matching these types of
changes. Bug fixes would have a higher priority, less chance
to break backward compatibility and more chance to be
incorporated earlier. 
 
It should be applied before patch 1077979, otherwise that
fix would be reversed.

In spite of the formatting comments above, there are
*valuable* changes in the submitted file.

This is a nice candidate to be tackled in a Python Bug Day,
since it functionality involves a broad range of platforms
and user browsers preferences. Moreover,  thourough test
cases are hard to be cooked.

I recommend keeping it open until somebody (possibly its
author) reshape it properly and then applying it.
History
Date User Action Args
2007-08-23 15:26:19adminlinkissue728278 messages
2007-08-23 15:26:19admincreate