Message40754
Logged In: YES
user_id=580015
I'm afraid my idea of patch size comes from GCC land, where
this would be considered not that big at all. Only 1500
lines affected, and more than half of that is documentation
and test suite!
I tried, and failed, to break up the changes to tempfile.py
itself. But there's some larger divisions that could be
made. We could check in the new test_tempfile.py now,
disabling the tests that refer to nonexistent functions
(just comment out the lines that add those tests to the
test_classes array). The changes to the rest of the test
suite are also largely independent of the tempfile.py
rewrite (since they replace tempfile.mktemp() with TESTFN,
mostly). And the search-and-replace changes in the library
can wait until after tempfile.py itself gets reviewed.
Unfortunately, I am about to go on vacation for five days,
so I don't have time now to do this split-up. I will try
to drum up interest on python-dev in reviewing the patch as is.
|
|
Date |
User |
Action |
Args |
2007-08-23 15:14:23 | admin | link | issue589982 messages |
2007-08-23 15:14:23 | admin | create | |
|