This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author rhettinger
Recipients
Date 2002-09-09.04:03:37
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Logged In: YES 
user_id=80475

Whew!  It takes just as long to check as 6000 line diff as it 
does to create the thing in the first place.

The patch is accepted and ready to commit after the 
following corrections and review notes are addressed.

Since several errors were syntactical, they could be caught 
by running the script.  I recommend that all of the scripts 
be run one time before a final commit.

Also, anoter additional check would be useful.  Everywhere 
a function defined the likes of _find=string.find, re-verify 
that every instance of _find was fixed-up (I cannot check 
this from the diff file).

Corrections and review notes (also attached as a separate 
file):

In file:  AutoIndent.py
Replace:  have = len(chars.expand(tabwidth))
With:  have = len(chars.expandtabs(tabwidth))

In file:  EditorWindow.py
Replace: line.find('python') >= 0
With: 'python' in line

In file:  FormatParagraph.py           
Replace:  data = "\n".join("\n")
With:  data = "\n".join(lines)

In file:  PyParse.py
Replace:  return len(str[self.stmt_start:i].expandtabs(,
With:  return len(str[self.stmt_start:i].expandtabs(\

In file:  byteyears.py
Replace:  print file.ljust(file, maxlen),
With:  print file.ljust(maxlen),

In file:  fixheader.py
Reverify propriety of substitution:  if ord(c)<=0x80 and 
c.isalnum()

In file:  mailerdaemon.py
Replace:  if sub.find('warning') >= 0: return 1
With:  if 'warning' in sub: return 1

In file:  mailerdaemon.py
Replace:  errors.append(''.join((email.strip()+': '+res.group
('reason')).split()))
With:  errors.append(' '.join((email.strip()+': '+res.group
('reason')).split()))

In file:  mailerdaemon.py
errors.append(''.join((email.strip()+': '+reason).split()))
errors.append(' '.join((email.strip()+': '+reason).split()))

In file:  objgraph.py
Replace:  ! /usr/bin/env python
With:  #! /usr/bin/env python

In file:  pathfix.py
Replace:  if line.find("python") < 0:
With:  if "python" in line:

In file:  texi2html.py
I don't understand the <<<<<< additions

In file:  treesync.py
Replace:  split(e.split('/')
With:  e.split('/')




History
Date User Action Args
2007-08-23 15:13:47adminlinkissue572113 messages
2007-08-23 15:13:47admincreate