Author rhettinger
Recipients
Date 2002-05-08.07:20:39
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to
Content
Logged In: YES 
user_id=80475

Here are a few thoughts from my review:

Patch needs to diff from current version, 2.173 of object.c

Patch compiles okay.  Code passes regrtest.py without 
generating warnings.  Code agrees with docs.  Scanned 
remaining code base and found no other direct calls to 
tp_compare in other *.c or *.h files.

If this were an error rather than a warning, convention 
would indicate a BadInternalCall since this can only be 
generated by an extension writer.  I'm wondering if we are 
warning the wrong person.  An old extension recompiled for 
Py2.3 will compile fine but then warn an end-user (not the 
extension writer) about a mysterious tp_compare that they 
can neither see, nor touch.

In try_3way_compare, the warning is not given for 
instances.  Are we exempting instances from the warnings?

In try_3way_compare, the warning is given in the 
section, "v's comparison" but is omitted in "w's 
comparison" which follows.

I think the priority should be raised on this patch because 
it needs to be in-place for Py2.3a so that we get the 
earliest possible notice if the warning clashes with use in 
one of the popular extensions.
History
Date User Action Args
2007-08-23 15:08:25adminlinkissue472523 messages
2007-08-23 15:08:25admincreate