Message 294763 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	pitrou, serhiy.storchaka, vstinner
Date	2017-05-30.14:37:47
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1496155067.24.0.416474984897.issue30509@psf.upfronthosting.co.za>
In-reply-to

Content
The PR makes different changes: * replace lookup_method() with lookup_maybe_method() * specialize call_xxx() functions for a fixed number of parameters * rename lookup_maybe() to _PyObject_LookupSpecial() If possible, I would prefer to not have to duplicate functions for 0, 1 and 2 parameters (3 variants). I would like to know which changes are responsible for the speedup. To ease the review, would it be possible to split your change into smaller changes? At least, separated commits, maybe even a first "cleanup" PR before the "optimization" PR.

The PR makes different changes:

* replace lookup_method() with lookup_maybe_method()
* specialize call_xxx() functions for a fixed number of parameters
* rename lookup_maybe() to _PyObject_LookupSpecial()

If possible, I would prefer to not have to duplicate functions for 0, 1 and 2 parameters (3 variants). I would like to know which changes are responsible for the speedup.

To ease the review, would it be possible to split your change into smaller changes? At least, separated commits, maybe even a first "cleanup" PR before the "optimization" PR.

History
Date	User	Action	Args
2017-05-30 14:37:47	vstinner	set	recipients: + vstinner, pitrou, serhiy.storchaka
2017-05-30 14:37:47	vstinner	set	messageid: <1496155067.24.0.416474984897.issue30509@psf.upfronthosting.co.za>
2017-05-30 14:37:47	vstinner	link	issue30509 messages
2017-05-30 14:37:47	vstinner	create