Message 294690 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	serhiy.storchaka
Recipients	christian.heimes, serhiy.storchaka
Date	2017-05-29.12:12:06
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1496059928.05.0.652523120979.issue30502@psf.upfronthosting.co.za>
In-reply-to

Content
Your PR LGTM. But I think the code can be much simpler. Here is a patch that shares common code and applies other simplifications to surrounded code. PR 1852 increases the total number of lines by 37 lines, issue30502-simpler.diff -- only by 3 lines. PR 1852: 1 file changed, 49 insertions(+), 12 deletions(-) issue30502-simpler.diff: 1 file changed, 46 insertions(+), 43 deletions(-)

Your PR LGTM. But I think the code can be much simpler.

Here is a patch that shares common code and applies other simplifications to surrounded code. PR 1852 increases the total number of lines by 37 lines, issue30502-simpler.diff -- only by 3 lines.

PR 1852: 1 file changed, 49 insertions(+), 12 deletions(-)
issue30502-simpler.diff: 1 file changed, 46 insertions(+), 43 deletions(-)

History
Date	User	Action	Args
2017-05-29 12:12:08	serhiy.storchaka	set	recipients: + serhiy.storchaka, christian.heimes
2017-05-29 12:12:08	serhiy.storchaka	set	messageid: <1496059928.05.0.652523120979.issue30502@psf.upfronthosting.co.za>
2017-05-29 12:12:08	serhiy.storchaka	link	issue30502 messages
2017-05-29 12:12:07	serhiy.storchaka	create