Author haypo
Recipients BreamoreBoy, Pranav Deshpande, barry, haypo, r.david.murray
Date 2017-05-16.21:20:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1494969614.53.0.643625948907.issue18299@psf.upfronthosting.co.za>
In-reply-to
Content
I really hate script_helper API: keyword arguments are only used to pass environment variables, so the function uses hackish parameteres like __cleanenv=True...

I would prefer to pass keywords unchanged to Popen() to be able to use universal_newlines=True for example.

Since we have +10k tests, I suggest to not touch the existing API but add yet another API: a new function in support/script_helper.py.

What do you think?
History
Date User Action Args
2017-05-16 21:20:14hayposetrecipients: + haypo, barry, r.david.murray, BreamoreBoy, Pranav Deshpande
2017-05-16 21:20:14hayposetmessageid: <1494969614.53.0.643625948907.issue18299@psf.upfronthosting.co.za>
2017-05-16 21:20:14haypolinkissue18299 messages
2017-05-16 21:20:14haypocreate