Author neeverett
Recipients eryksun, neeverett, paul.moore, steve.dower, tim.golden, zach.ware
Date 2017-05-16.08:48:17
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1494924498.2.0.467219156017.issue30374@psf.upfronthosting.co.za>
In-reply-to
Content
I think the original author adds the relative path "%APPDATA%..." with the intention to keep it effective even when the set path of APPDATA changes. However that compulsively changes the type of PATH var to REG_EXPAND_SZ.

It is reasonable that the type of PATH var should not be changed. So I think when the type is REG_SZ, not adding the %APPDATA% path and instead adding the absolute path of it should be a good idea.

I just modified my PR and fixed it this way, along with other problems that Eryk Sun mentioned.
History
Date User Action Args
2017-05-16 08:48:18neeverettsetrecipients: + neeverett, paul.moore, tim.golden, zach.ware, eryksun, steve.dower
2017-05-16 08:48:18neeverettsetmessageid: <1494924498.2.0.467219156017.issue30374@psf.upfronthosting.co.za>
2017-05-16 08:48:18neeverettlinkissue30374 messages
2017-05-16 08:48:17neeverettcreate