Message 290058 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	serhiy.storchaka
Recipients	eric.snow, ncoghlan, serhiy.storchaka, vstinner
Date	2017-03-23.18:36:58
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1490294218.68.0.298732326103.issue29881@psf.upfronthosting.co.za>
In-reply-to

Content
Some code (_PyUnicode_FromId, bool_repr, create_filter) could be simpler if make _PY_ONCEVAR_INIT returning the value (NULL in case of error). The signature of _PY_ONCEVAR_INIT() is the same as of _Py_SETREF(). If var == NULL both `_PY_ONCEVAR_INIT(var, expr)` and `_Py_SETREF(var, expr)` are equivalent to just `var = expr`. Maybe rename _PY_ONCEVAR_INIT to _Py_SET_ONCE?

Some code (_PyUnicode_FromId, bool_repr, create_filter) could be simpler if make _PY_ONCEVAR_INIT returning the value (NULL in case of error).

The signature of _PY_ONCEVAR_INIT() is the same as of _Py_SETREF(). If var == NULL both `_PY_ONCEVAR_INIT(var, expr)` and `_Py_SETREF(var, expr)` are equivalent to just `var = expr`. Maybe rename _PY_ONCEVAR_INIT to _Py_SET_ONCE?

History
Date	User	Action	Args
2017-03-23 18:36:58	serhiy.storchaka	set	recipients: + serhiy.storchaka, ncoghlan, vstinner, eric.snow
2017-03-23 18:36:58	serhiy.storchaka	set	messageid: <1490294218.68.0.298732326103.issue29881@psf.upfronthosting.co.za>
2017-03-23 18:36:58	serhiy.storchaka	link	issue29881 messages
2017-03-23 18:36:58	serhiy.storchaka	create