Message 288137 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	methane
Recipients	brett.cannon, eric.snow, fdrake, methane, ncoghlan
Date	2017-02-19.14:23:49
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1487514229.9.0.557887011851.issue29592@psf.upfronthosting.co.za>
In-reply-to

Content
I got it. removeduppaths() may change relpath in sys.path to absolute path. abs_paths() changes __file__ and __cached__ for consistency with the changed sys.path. I updated PR 167 to call abs_paths() only if removeduppaths() modified sys.path. Strictly speaking, abs_paths() is required only when removeduppaths() converted relpath to absolute path. But because duplicated paths are rare too, I think this approach is practical enough.

I got it.
removeduppaths() may change relpath in sys.path to absolute path.
abs_paths() changes __file__ and __cached__ for consistency with the changed sys.path.

I updated PR 167 to call abs_paths() only if removeduppaths() modified sys.path.
Strictly speaking, abs_paths() is required only when removeduppaths() converted relpath to absolute path.

But because duplicated paths are rare too, I think this approach is practical enough.

History
Date	User	Action	Args
2017-02-19 14:23:49	methane	set	recipients: + methane, fdrake, brett.cannon, ncoghlan, eric.snow
2017-02-19 14:23:49	methane	set	messageid: <1487514229.9.0.557887011851.issue29592@psf.upfronthosting.co.za>
2017-02-19 14:23:49	methane	link	issue29592 messages
2017-02-19 14:23:49	methane	create