Message 287470 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	methane, python-dev, rhettinger, serhiy.storchaka, vstinner, yselivanov
Date	2017-02-09.23:50:15
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1486684216.09.0.492045050526.issue29507@psf.upfronthosting.co.za>
In-reply-to

Content
callmethod2.patch: I like that change on object_vacall(), I'm not sure about the change on PyObject_CallMethod*() only for empty format string. I suggest to split your patch into two parts, and first focus on object_vacall(). Do you have a benchmark for this one? Note: I doesn't like the name I chose for object_vacall(). If we modify it, I would suggest to rename it objet_call_vargs() instead. Anyway, before pushing anything more, I would like to take a decision on the repr()/test_exceptions issue. What do you think Naoki?

callmethod2.patch: I like that change on object_vacall(), I'm not sure about the change on PyObject_CallMethod*() only for empty format string.

I suggest to split your patch into two parts, and first focus on object_vacall(). Do you have a benchmark for this one?

Note: I doesn't like the name I chose for object_vacall(). If we modify it, I would suggest to rename it objet_call_vargs() instead.

Anyway, before pushing anything more, I would like to take a decision on the repr()/test_exceptions issue. What do you think Naoki?

History
Date	User	Action	Args
2017-02-09 23:50:16	vstinner	set	recipients: + vstinner, rhettinger, methane, python-dev, serhiy.storchaka, yselivanov
2017-02-09 23:50:16	vstinner	set	messageid: <1486684216.09.0.492045050526.issue29507@psf.upfronthosting.co.za>
2017-02-09 23:50:16	vstinner	link	issue29507 messages
2017-02-09 23:50:15	vstinner	create