Message285139
Not really related to this fix, but a colleague also prudently pointed out that perhaps an
assert file[:prefix_len] == build_dir + os.sep
before the
outputs.append(os.path.join(self.install_dir,
file[prefix_len:]))
in the helper for pure modules (_pure_outputs after my patch is applied) would be in order, to assert that what is cut away is what was intended.
That sounds like a good idea to me, but could it give false negatives on Windows (case-insensitive file systems? or file systems where both / and \ are allowed?). |
|
Date |
User |
Action |
Args |
2017-01-10 18:06:51 | Elvis Stansvik | set | recipients:
+ Elvis Stansvik, eric.araujo, dstufft |
2017-01-10 18:06:51 | Elvis Stansvik | set | messageid: <1484071611.11.0.715056497855.issue29225@psf.upfronthosting.co.za> |
2017-01-10 18:06:51 | Elvis Stansvik | link | issue29225 messages |
2017-01-10 18:06:50 | Elvis Stansvik | create | |
|