This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients serhiy.storchaka, vstinner
Date 2016-11-30.11:49:26
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1480506566.65.0.668770988141.issue28839@psf.upfronthosting.co.za>
In-reply-to
Content
fastcalldict.patch avoided INCREF/DECREF on keyword keys and values. This is wrong: we must hold strong references because the keyword dictionary can be technically modified: see issue #2016 and test_extcall.

Hum, I'm quite sure that it's not the first time that I was bitten by this bug. That's maybe why I didn't try to implement this optimization the first time.

fastcalldict-2.patch keeps INCREF/DECREF and so doesn't crash on test_extcall.
History
Date User Action Args
2016-11-30 11:49:26vstinnersetrecipients: + vstinner, serhiy.storchaka
2016-11-30 11:49:26vstinnersetmessageid: <1480506566.65.0.668770988141.issue28839@psf.upfronthosting.co.za>
2016-11-30 11:49:26vstinnerlinkissue28839 messages
2016-11-30 11:49:26vstinnercreate