Message282080
fastcalldict.patch avoided INCREF/DECREF on keyword keys and values. This is wrong: we must hold strong references because the keyword dictionary can be technically modified: see issue #2016 and test_extcall.
Hum, I'm quite sure that it's not the first time that I was bitten by this bug. That's maybe why I didn't try to implement this optimization the first time.
fastcalldict-2.patch keeps INCREF/DECREF and so doesn't crash on test_extcall. |
|
Date |
User |
Action |
Args |
2016-11-30 11:49:26 | vstinner | set | recipients:
+ vstinner, serhiy.storchaka |
2016-11-30 11:49:26 | vstinner | set | messageid: <1480506566.65.0.668770988141.issue28839@psf.upfronthosting.co.za> |
2016-11-30 11:49:26 | vstinner | link | issue28839 messages |
2016-11-30 11:49:26 | vstinner | create | |
|