Message25505
Logged In: YES
user_id=21627
The patch is fine, please apply.
As for generalising Py_off_t: there are some issues which I
keep forgetting. fpos_t is not guaranteed to be an integral
type, and indeed, on Linux, it is not. I'm not quite
completely sure why this patch works; I think that on all
platforms where fpos_t is not integral, off_t happens to be
large enough. The only case where off_t is not large enough
is (IIRC) Windows, where fpos_t can be used.
So this is all somewhat muddy, and if this gets generalized,
a more elaborate comment seems to be in order. |
|
Date |
User |
Action |
Args |
2007-08-23 14:32:20 | admin | link | issue1215928 messages |
2007-08-23 14:32:20 | admin | create | |
|