This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author steve.dower
Recipients Jeff.Kaufman, Joshua.Landau, NeilGirdhar, SpaghettiToastBook, andybuckley, belopolsky, benjamin.peterson, berker.peksag, eric.snow, ethan.furman, ezio.melotti, georg.brandl, gvanrossum, ncoghlan, paul.moore, pconnell, r.david.murray, steve.dower, terry.reedy, twouters, zbysz
Date 2015-04-15.15:18:20
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1429111101.31.0.634828413883.issue2292@psf.upfronthosting.co.za>
In-reply-to
Content
I have limited expertise in most of these areas, but I looked at starunpack40.diff and have these comments:

* tests look to have good coverage of the feature (can't speak to coverage of the parser/compiler code)
* parsermodule.c changes comprehension handling, but I thought we pulled this out?
* why was dictobject.c.h added? I don't understand clinic thoroughly, but it seems a lot of new code for what was changed in dictobject.c
* can the BUILD_(TUPLE|LIST)_UNPACK code in ceval.c share most of the processing? Or is there an unwanted perf impact to that?
* whoever applies the patch should regenerate importlib.h themselves - just a reminder

Otherwise, I didn't see anything that particularly scared me. Since we apparently don't have anyone willing and with the expertise to thoroughly check the patch, I'd vote for checking it in asap so it has more releases to bake before 3.5 final.
History
Date User Action Args
2015-04-15 15:18:21steve.dowersetrecipients: + steve.dower, gvanrossum, twouters, georg.brandl, terry.reedy, paul.moore, ncoghlan, belopolsky, benjamin.peterson, ezio.melotti, andybuckley, r.david.murray, zbysz, ethan.furman, eric.snow, berker.peksag, Joshua.Landau, pconnell, NeilGirdhar, Jeff.Kaufman, SpaghettiToastBook
2015-04-15 15:18:21steve.dowersetmessageid: <1429111101.31.0.634828413883.issue2292@psf.upfronthosting.co.za>
2015-04-15 15:18:21steve.dowerlinkissue2292 messages
2015-04-15 15:18:20steve.dowercreate