Message24088
Logged In: YES
user_id=6380
+1.
minor nits:
in the main patch: instead of
+ if line.endswith('\n'):
+ last_line_lfend = True
+ else:
+ last_line_lfend = False
you can just use
last_line_lfend = line.endswith('\n')
in the unit test: instead of
if type(a) != type(0):
use
if not isinstance(a, int):
so that if some future release changes file.closed to return
a bool (as it should :-) this test won't break.
Is tehre a reason why you're not patching the fp.readline()
call in parse_multipart()? It would seem to have the same
issue (even if it isn't used in Zope :-). |
|
Date |
User |
Action |
Args |
2007-08-23 14:29:11 | admin | link | issue1112549 messages |
2007-08-23 14:29:11 | admin | create | |
|