Message24087
Logged In: YES
user_id=32974
Yup, test/output/test_cgi did need fixing. Apologies, I did not understand
the test regime. A new patch file named test_output_test_cgi-
svn-50879.patch has been uploaded with the required change. regrtest.py
now passes.
As far as verify vs. vereq, the test_cgi module uses verify all over the place.
I'm apt to not change all of those places, so to change it in just that one place
is probably ineffective. Same for type comparison vs. isinstance. I'm trying to
make the smallest change possible as opposed to refactoring the test
module.
I've uploaded a patch which contains a) the fix to cgi.py, b) the fix to
test_cgi.py, and the fix to output/test_cgi.
The stylistic change wrt to last_line_lfend is fine with me, but I'll leave that
jugment to someone else.
I'm not sure how to ensure the fix doesn't create other problems other than
what has already been done by proving it still passes the tests it was
subjected to in the "old" test suite and adds new tests that prove it no longer
has the denial of service problem. |
|
Date |
User |
Action |
Args |
2007-08-23 14:29:10 | admin | link | issue1112549 messages |
2007-08-23 14:29:10 | admin | create | |
|