This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients Alexander.Todorov, martin.panter, orsenthil
Date 2015-03-17.02:01:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1426557675.42.0.970738101658.issue22891@psf.upfronthosting.co.za>
In-reply-to
Content
The patch seems sensible. The only behaviour change I can forsee would be the odd case of http:1234 no longer being parsed like this:

>>> urlsplit("http:1234")
SplitResult(scheme='http', netloc='', path='1234', query='', fragment='')

Instead it would be parsed the same as HTTP:1234 (or tel:1234!):

>>> urlsplit("HTTP:1234")
SplitResult(scheme='', netloc='', path='HTTP:1234', query='', fragment='')

If optimizing for “http:” really is important, it might still be done without the code duplication. Other options might be factoring a subroutine, using str.strip(), set.issubset(), or regular expressions.
History
Date User Action Args
2015-03-17 02:01:15martin.pantersetrecipients: + martin.panter, orsenthil, Alexander.Todorov
2015-03-17 02:01:15martin.pantersetmessageid: <1426557675.42.0.970738101658.issue22891@psf.upfronthosting.co.za>
2015-03-17 02:01:15martin.panterlinkissue22891 messages
2015-03-17 02:01:14martin.pantercreate