Message22758
Logged In: YES
user_id=6380
(I'm sure Barry didn't mind, I just assigned it to him
because rev. 1.27 had his name on it. :-)
I saw the patch, don't have time to apply it, note that it
has three(!) nested try-except blocks; instead, it should
really have some smaller ones around just exactly the call
that you expect to raise an exception. Exceptions elsewhere
should *not* be caught.
Also, the raise statement in handle_error() should just be
"raise" without parameters, which re-raises the original
exception. The exception already contains the filename, usually.
Finally: os.walk() seems to suppress errors in os.listdir().
Technically, errors in os.listdir() should be treated the
same as errors in os.remove() / os.rmdir(), but that means
we can't use os.walk() -- or we'd have to add error handling
to it recursively. |
|
| Date |
User |
Action |
Args |
| 2007-08-23 14:26:48 | admin | link | issue1048941 messages |
| 2007-08-23 14:26:48 | admin | create | |
|