Message221262
Hi Raymond, Martin,
I won't feel bad about this patch not making it into the final Python distribution. I worked on this bug because it was the only "core C" bug at PyCon US sprints for CPython. I learned a bit more about CPython while working on it and I don't consider the time I spent on this bug as wasted.
Other than symmetry arguments, I can't think of any other argument for islice to accept large values.
a = []
a[sys.maxsize+2:] # gives: []
islice(a, None, sys.maxsize+2) # raises exception
But because islice has to go through the elements of the iterable from the current value to "start", while the first example doesn't, I don't think the symmetry argument is that strong here.
So, I think it's fine if we close this bug without accepting this patch.
Thanks for your time in reviewing it! |
|
Date |
User |
Action |
Args |
2014-06-22 15:48:03 | AlokSinghal | set | recipients:
+ AlokSinghal, loewis, rhettinger, terry.reedy, thomasguest |
2014-06-22 15:48:03 | AlokSinghal | set | messageid: <1403452083.14.0.40154863438.issue6305@psf.upfronthosting.co.za> |
2014-06-22 15:48:03 | AlokSinghal | link | issue6305 messages |
2014-06-22 15:48:03 | AlokSinghal | create | |
|