Message 215490 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	eryksun
Recipients	dmo2118, eryksun, stutzbach
Date	2014-04-04.05:28:56
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1396589336.74.0.972755397546.issue21151@psf.upfronthosting.co.za>
In-reply-to

Content
In Py2Reg, the REG_BINARY (3) case sets `retDataSize = 0` when the value is None: http://hg.python.org/cpython/file/04f714765c13/PC/winreg.c#l766 It doesn't modify retDataBuf. Then in PySetValueEx, PyMem_DEL is called for the uninitialized address in data: http://hg.python.org/cpython/file/04f714765c13/PC/winreg.c#l1566 Py2Reg in this case could also set `*retDataBuf = NULL`. RegSetValueEx allows lpData to be NULL when cbData is 0. http://msdn.microsoft.com/en-us/library/ms724923

In Py2Reg, the REG_BINARY (3) case sets `*retDataSize = 0` when the value is None: 

http://hg.python.org/cpython/file/04f714765c13/PC/winreg.c#l766

It doesn't modify *retDataBuf. Then in PySetValueEx, PyMem_DEL is called for the uninitialized address in data:

http://hg.python.org/cpython/file/04f714765c13/PC/winreg.c#l1566

Py2Reg in this case could also set `*retDataBuf = NULL`. RegSetValueEx allows lpData to be NULL when cbData is 0. 

http://msdn.microsoft.com/en-us/library/ms724923

History
Date	User	Action	Args
2014-04-04 05:28:56	eryksun	set	recipients: + eryksun, stutzbach, dmo2118
2014-04-04 05:28:56	eryksun	set	messageid: <1396589336.74.0.972755397546.issue21151@psf.upfronthosting.co.za>
2014-04-04 05:28:56	eryksun	link	issue21151 messages
2014-04-04 05:28:56	eryksun	create