Message209230
_PyType_GetDocFromInternalDoc and _PyType_GetTextSignatureFromInternalDoc declarations are too long. could you please wrap them around?
First parameter of class methods (e.g. dict.fromkeys) now has a type of object (PyDictObject *) instead of PyTypeObject * (or PyDict_Type *).
There is redundant cast in dict___contains__:
register PyDictObject *mp = (PyDictObject *)self;
First parameter of static methods (e.g. str.maketrans) now has a type of object (PyUnicodeObject *) instead of void *.
There is redundant cast in unicodedata_UCD_decimal_impl:
PyUnicodeObject *v = (PyUnicodeObject *)unichr;
Perhaps here should be os.path.dirname() instead of os.path.basename():
dirname = os.path.basename(destination.filename)
The 'fail("Can't write to destination "' line is too long. And I think it will look better if use string formatting. |
|
Date |
User |
Action |
Args |
2014-01-25 19:50:03 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, ncoghlan, larry, zach.ware |
2014-01-25 19:50:03 | serhiy.storchaka | set | messageid: <1390679403.47.0.124637482587.issue20390@psf.upfronthosting.co.za> |
2014-01-25 19:50:03 | serhiy.storchaka | link | issue20390 messages |
2014-01-25 19:50:03 | serhiy.storchaka | create | |
|