This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author rmsr
Recipients larry, rmsr, serhiy.storchaka, zach.ware
Date 2014-01-19.07:23:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1390116187.15.0.825078287966.issue20294@psf.upfronthosting.co.za>
In-reply-to
Content
I have reviewed this as best I am able. I'll be honest that a lot of clinic.py makes my eyes cross; I'm used to webdev templating, which is inverted from AC (flow control inside the template). Not complaining, it's a complicated subject. I do like the centralization of the templates.

I didn't see anything that jumped out at me. I tried out the new conversions on socketmodule and like the output, and none of the existing conversions mutated. So LGTM!

It took me a while to figure out how to make __new__ a class method though, decorator support should probably be documented (or else a hint like '__new__ must be a @classmethod!')
History
Date User Action Args
2014-01-19 07:23:07rmsrsetrecipients: + rmsr, larry, zach.ware, serhiy.storchaka
2014-01-19 07:23:07rmsrsetmessageid: <1390116187.15.0.825078287966.issue20294@psf.upfronthosting.co.za>
2014-01-19 07:23:07rmsrlinkissue20294 messages
2014-01-19 07:23:06rmsrcreate