This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients akitada, benjamin.peterson, cben, eric.araujo, loewis, mu_mind, ness, ping, r.david.murray, rhettinger, taschini, vstinner
Date 2014-01-05.03:31:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1388892669.23.0.791564107296.issue1065986@psf.upfronthosting.co.za>
In-reply-to
Content
Made some review comments.

Looks good in general and it seems like the tests are fairly comprehensive.  I haven't tried to run any additional experiments, but I don't see how it could make things worse, since the new code paths will only do something different if unicode objects are actually involved.
History
Date User Action Args
2014-01-05 03:31:09r.david.murraysetrecipients: + r.david.murray, loewis, ping, rhettinger, cben, vstinner, benjamin.peterson, eric.araujo, akitada, mu_mind, ness, taschini
2014-01-05 03:31:09r.david.murraysetmessageid: <1388892669.23.0.791564107296.issue1065986@psf.upfronthosting.co.za>
2014-01-05 03:31:09r.david.murraylinkissue1065986 messages
2014-01-05 03:31:08r.david.murraycreate