Message205263
Thanks for the patch! Some comments:
1. It should path objects as well as str objects.
2. I don't think you have to call resolve() here.
3. you should probably test what happens when one of the files doesn't exist
4. you need to update the documentation too |
|
Date |
User |
Action |
Args |
2013-12-04 23:30:27 | pitrou | set | recipients:
+ pitrou, gvanrossum, vstinner, Arfrever, vajrasky |
2013-12-04 23:30:27 | pitrou | set | messageid: <1386199827.46.0.542214076478.issue19775@psf.upfronthosting.co.za> |
2013-12-04 23:30:27 | pitrou | link | issue19775 messages |
2013-12-04 23:30:27 | pitrou | create | |
|