Message 204308 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	gregory.p.smith
Recipients	asvetlov, cvrebert, ezio.melotti, gregory.p.smith, pitrou, rosslagerwall, sarum9in, sbt, vstinner
Date	2013-11-25.08:29:13
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1385368154.73.0.441878982679.issue15798@psf.upfronthosting.co.za>
In-reply-to

Content
adding {0,1,2} to fds_to_keep (populated from pass_fds) is indeed an alternate approach. A variant of an alternate patch doing that attached. This actually simplifies code. Is there anything this would hurt that i'm not seeing? I suppose it adds minor overhead to the fork_exec() call by passing more in and lookups into the fds_to_keep list now that it will always contain at least 4 values instead of the previous 1. I doubt that is matters (I haven't measured anything).

adding {0,1,2} to fds_to_keep (populated from pass_fds) is indeed an alternate approach.  A variant of an alternate patch doing that attached.

This actually simplifies code.  Is there anything this would hurt that i'm not seeing?

I suppose it adds minor overhead to the fork_exec() call by passing more in and lookups into the fds_to_keep list now that it will always contain at least 4 values instead of the previous 1.  I doubt that is matters (I haven't measured anything).

History
Date	User	Action	Args
2013-11-25 08:29:14	gregory.p.smith	set	recipients: + gregory.p.smith, pitrou, vstinner, ezio.melotti, cvrebert, asvetlov, rosslagerwall, sbt, sarum9in
2013-11-25 08:29:14	gregory.p.smith	set	messageid: <1385368154.73.0.441878982679.issue15798@psf.upfronthosting.co.za>
2013-11-25 08:29:14	gregory.p.smith	link	issue15798 messages
2013-11-25 08:29:14	gregory.p.smith	create