Message199456
> This looks fine. Can you quantify where the speedup comes from?
From all changes, but mainly the ASCII special-casing and the new
buffering.
> Reading the code, I see we now maintain a small internal buffer in
> the file object, rather than using stack allocation at the call
> sites. It is unclear to me how this saves memory, since the amount
> of memory copying should be the same.
No, memory copying is suppressed in many cases.
> Have you looked at providing a special opcode for a few other magic
> numbers?(We have that in our own custom marshal format)
> Some very common values are:
> empty tuple
> 0
> 1
It shouldn't be useful since marshal memoizes them anyway: only the
first appearance in a pyc file would benefit. |
|
Date |
User |
Action |
Args |
2013-10-11 09:51:56 | pitrou | set | recipients:
+ pitrou, barry, kristjan.jonsson, vstinner, christian.heimes |
2013-10-11 09:51:56 | pitrou | link | issue19219 messages |
2013-10-11 09:51:56 | pitrou | create | |
|