This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author tim.peters
Recipients pitrou, sbt, tim.peters, vstinner
Date 2013-10-08.18:58:36
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1381258716.17.0.244545182739.issue19158@psf.upfronthosting.co.za>
In-reply-to
Content
Antoine, how strongly do you feel about this?  I confess I don't get it.  Copy+paste code duplication doesn't help any of readability, correctness, or ease of future maintenance, so I guess it's some micro-efficiency concern.  Really?! ;-)

Note that the patch doesn't _introduce_ calling the base class .release() - the code always did that.  All it does is put the pre-existing code in a `with:` block.  Minimal change.  Yes, the pre-existing code had to be indented, but no non-whitespace character changed.

Of course in this case it's trivial either way.  So if I have to duplicate the code to get your blessing, fine.  On the other hand, since it _is_ trivial either way, I'd rather not bother ;-)
History
Date User Action Args
2013-10-08 18:58:36tim.peterssetrecipients: + tim.peters, pitrou, vstinner, sbt
2013-10-08 18:58:36tim.peterssetmessageid: <1381258716.17.0.244545182739.issue19158@psf.upfronthosting.co.za>
2013-10-08 18:58:36tim.peterslinkissue19158 messages
2013-10-08 18:58:36tim.peterscreate