Author oscarbenjamin
Recipients Jeffrey.Armstrong, Martin.Fiers, Pete.Forman, RubyTuesdayDONO, Seppo.Yli-Olli, alexis, christian.heimes, cmcqueen1975, danmbox, doko, fratti, geertj, jkloth, jonforums, jwilk, lemburg, loewis, merwok, oscarbenjamin, paul.moore, pje, renatosilva, rivy, rpetrov, rubenvb, santoso.wijaya, schmir, tarek
Date 2013-08-21.17:14:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAHVvXxTaYv9a66PVEXqJBOR=0tfnTvQGeJjf0SK65P-L3z-ZHQ@mail.gmail.com>
In-reply-to <1377016150.94.0.826022208403.issue12641@psf.upfronthosting.co.za>
Content
I just noticed today that the fix that implemented by these patches
(only providing -mno-cygwin if gcc_ver < 4) is also used by numpy's
distutils. You can see the relevant code here:

https://github.com/numpy/numpy/blob/master/numpy/distutils/mingw32ccompiler.py#L117

The relevant commit was three years ago:

https://github.com/numpy/numpy/commit/9dd7c7b8ad826beefbbc0c10ff457c62f1be223d

They haven't bothered with checking for cygwin gcc (my patches only do
this to try and show a helpful error message).
History
Date User Action Args
2013-08-21 17:14:27oscarbenjaminsetrecipients: + oscarbenjamin, lemburg, loewis, doko, paul.moore, pje, geertj, christian.heimes, schmir, tarek, jkloth, jwilk, merwok, rpetrov, cmcqueen1975, rubenvb, santoso.wijaya, alexis, Seppo.Yli-Olli, jonforums, RubyTuesdayDONO, Jeffrey.Armstrong, danmbox, Martin.Fiers, Pete.Forman, renatosilva, fratti, rivy
2013-08-21 17:14:27oscarbenjaminlinkissue12641 messages
2013-08-21 17:14:27oscarbenjamincreate